RCAL-977 - Version datamodels #445
Open
+175
−180
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
8 tasks
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #445 +/- ##
==========================================
- Coverage 97.56% 97.35% -0.21%
==========================================
Files 30 36 +6
Lines 2788 3252 +464
==========================================
+ Hits 2720 3166 +446
- Misses 68 86 +18 ☔ View full report in Codecov by Sentry. |
|
Is this something you'd want to present on a Thursday tag up? |
Good idea! Let's do it. |
WilliamJamieson
force-pushed
the
versioned_2
branch
from
e187307 to
d3d5bbf
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves RCAL-977
This PR (with the corresponding RAD changes: spacetelescope/rad#528) adds support for versioning DataModels. The approach is similar to #305 where with this PR the link between a specific tag and Node class and removed. Instead Node classes have a tag "pattern" (wildcard) which can match one of multiple tag versions. New Node instances use the latest tag version except for when they are read from an ASDF file (where the version read from the file is used).
Regression tests all pass: https://github.com/spacetelescope/RegressionTests/actions/runs/12611441068
Once this PR (and spacetelescope/rad#528) are merged changes to schema can now be made in a way that retains opening existing files. To provide an example (and a toy change for reviewers to test):
braingram/rad#1
braingram#1
add a new entry to
cal_stepnamedtwo_step. Installing these branches allows creating and writing files with the newcal_step-2.0.0node but retains reading (and rewriting) ofcal_step-1.0.0nodes.Tasks
roman_datamodelstests.docs/page.no-changelog-entry-needed.)changes/:echo "changed something" > changes/<PR#>.<changetype>.rst(see below for change types).romancalregression test (https://github.com/spacetelescope/RegressionTests/actions/workflows/romancal.yml) with this branch installed ("git+https://github.com/<fork>/rad@<branch>").News fragment change types:
changes/<PR#>.feature.rst: new featurechanges/<PR#>.bugfix.rst: fixes an issuechanges/<PR#>.doc.rst: documentation changechanges/<PR#>.removal.rst: deprecation or removal of public APIchanges/<PR#>.misc.rst: infrastructure or miscellaneous change